-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Rollup of 8 pull requests #143459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #143459
Conversation
Add a test for various cases of invalid macro definitions. Closes: rust-lang#143351
This removes special-casing of boxes from `rustc_pattern_analysis`, as a first step in replacing `box_patterns` with `deref_patterns`. Incidentally, it fixes a bug caused by box patterns being represented as structs rather than pointers, where `exhaustive_patterns` could generate spurious `unreachable_patterns` lints on arms required for exhaustiveness; following the lint's advice would result in an error.
A blocking implementation of tcp4 write. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
std: sys: net: uefi: tcp4: Implement write A blocking implementation of tcp4 write.
…ser, r=jdonszelmann Port `#[non_exhaustive]` to the new attribute parsing infrastructure Ports `non_exhaustive` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? ``@jdonszelmann``
…nkov Remove names_imported_by_glob_use query. Based on rust-lang#143247 r? ``@ghost`` for perf
…errors Assign dependency bump PRs to me These PRs sometimes get lost as GH reduces their visibility, so I wanted to get an assignment so I can help these PRs land
…r=compiler-errors Remove some unnecessary `unsafe` in VecCache I'm pretty sure, but until perf confirms, r? ghost
…piler-errors mbe: Gracefully handle macro rules that end after `=>` Add a test for various cases of invalid macro definitions. Closes: rust-lang#143351
…adrieril remove special-casing of boxes from match exhaustiveness/usefulness analysis As a first step in replacing `box_patterns` with `deref_patterns`, this treats box patterns as deref patterns in the THIR and exhaustiveness analysis. This allows a bunch of special-casing to be removed. The emitted MIR is unchanged. Incidentally, this fixes a bug caused by box patterns being treated like structs rather than pointers, where enabling `exhaustive_patterns` (rust-lang#51085) could give rise to spurious `unreachable_patterns` lints on arms required for exhaustiveness. Following the lint's advice to remove the match arm would result in an error. I'm not sure what the current state of `exhaustive_patterns` is with regard to reference/box opsem, or whether there's any intention to have `unreachable_patterns` be more granular than the whole arm, but regardless this should hopefully make them easier to handle consistently. Tracking issue for deref patterns: rust-lang#87121 r? `@Nadrieril`
clean up GVN TypeId test addresses rust-lang#142789 (comment) This is an attempt to clarify what this test is actually supposed to test and make it less dependent on `TypeId` internals (it now depends on the output of `type_name` instead). I verified that this version still miscompiles on `nightly-2025-02-11`. r? ``@oli-obk`` ``@RalfJung``
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: e3843659e9 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing e384365 (parent) -> d98a5da (this PR) Test differencesShow 16 test diffsStage 1
Stage 2
Additionally, 10 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d98a5da813da67eb189387b8ccfb73cf481275d8 --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (d98a5da): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.5%, secondary -3.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 460.645s -> 460.925s (0.06%) |
Successful merges:
#[non_exhaustive]
to the new attribute parsing infrastructure #143085 (Port#[non_exhaustive]
to the new attribute parsing infrastructure)unsafe
in VecCache #143406 (Remove some unnecessaryunsafe
in VecCache)=>
#143408 (mbe: Gracefully handle macro rules that end after=>
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup